Skip to content

Scope info provider#1941

Merged
pokey merged 2 commits intomainfrom
pokey/scope-info-provider
Oct 30, 2023
Merged

Scope info provider#1941
pokey merged 2 commits intomainfrom
pokey/scope-info-provider

Conversation

@pokey
Copy link
Member

@pokey pokey commented Oct 12, 2023 •
edited
Loading

Checklist

  • I have added tests
  • [-] I have updated the docs and cheatsheet
  • [-] I have not broken the cheatsheet

@pokey pokey mentioned this pull request Oct 12, 2023
Merged
6 tasks
@pokey pokey force-pushed the pokey/scope-info-provider branch from c9fe1a3 to 3b17e39 Compare October 12, 2023 17:41
@pokey pokey force-pushed the pokey/get-custom-spoken-forms-from-talon branch 2 times, most recently from c4e7b75 to 6a6d06a Compare October 16, 2023 15:02
@pokey pokey force-pushed the pokey/scope-info-provider branch 2 times, most recently from 887c7df to 82a8ef5 Compare October 16, 2023 15:29
@pokey pokey force-pushed the pokey/get-custom-spoken-forms-from-talon branch 2 times, most recently from 6cc1055 to 6be3705 Compare October 16, 2023 15:47
@pokey pokey force-pushed the pokey/scope-info-provider branch from 074ddf4 to 33ce2a2 Compare October 16, 2023 15:47
@pokey pokey force-pushed the pokey/get-custom-spoken-forms-from-talon branch from 88d7ec1 to 84d2f1d Compare October 16, 2023 16:17
@pokey pokey force-pushed the pokey/scope-info-provider branch from ceaf377 to 1c6435b Compare October 16, 2023 16:17
@pokey pokey force-pushed the pokey/get-custom-spoken-forms-from-talon branch from dfba742 to 36bcc86 Compare October 17, 2023 13:55
@pokey pokey force-pushed the pokey/scope-info-provider branch from 7b220c3 to 0c5e9b3 Compare October 17, 2023 13:55
@pokey pokey force-pushed the pokey/get-custom-spoken-forms-from-talon branch from 60a927f to c07368a Compare October 17, 2023 14:11
@pokey pokey force-pushed the pokey/scope-info-provider branch from 3c5d883 to 962f921 Compare October 17, 2023 14:11
@pokey pokey force-pushed the pokey/get-custom-spoken-forms-from-talon branch from 07562d7 to 2e509b7 Compare October 18, 2023 15:07
@pokey pokey force-pushed the pokey/scope-info-provider branch from d80a73f to 9f61dd8 Compare October 18, 2023 15:08
@pokey pokey force-pushed the pokey/get-custom-spoken-forms-from-talon branch from 2e509b7 to 983ebe2 Compare October 18, 2023 15:08
@pokey pokey force-pushed the pokey/scope-info-provider branch from 9f61dd8 to 709fb57 Compare October 18, 2023 15:17
@pokey pokey force-pushed the pokey/get-custom-spoken-forms-from-talon branch from 983ebe2 to 516045d Compare October 18, 2023 15:17
@pokey pokey force-pushed the pokey/scope-info-provider branch from 709fb57 to d995f40 Compare October 18, 2023 15:57
@pokey pokey force-pushed the pokey/get-custom-spoken-forms-from-talon branch from 516045d to e71eb95 Compare October 18, 2023 15:57
@pokey pokey force-pushed the pokey/scope-info-provider branch from d995f40 to a977bf0 Compare October 20, 2023 12:45
@pokey pokey force-pushed the pokey/get-custom-spoken-forms-from-talon branch from 3abd5af to 896bbe4 Compare October 20, 2023 13:00
@pokey pokey force-pushed the pokey/scope-info-provider branch from a977bf0 to 49c3931 Compare October 20, 2023 13:00
@pokey pokey force-pushed the pokey/get-custom-spoken-forms-from-talon branch from 896bbe4 to c9f226b Compare October 20, 2023 13:07
@pokey pokey force-pushed the pokey/scope-info-provider branch 2 times, most recently from 2f3d43e to 156ff94 Compare October 20, 2023 13:18
@pokey pokey force-pushed the pokey/get-custom-spoken-forms-from-talon branch from bdcc34e to 0979cba Compare October 20, 2023 13:18
@pokey pokey force-pushed the pokey/scope-info-provider branch from beadd68 to 156ff94 Compare October 20, 2023 13:38
@pokey pokey force-pushed the pokey/scope-info-provider branch from 10712aa to 8c8fad8 Compare October 24, 2023 14:29
@pokey pokey force-pushed the pokey/get-custom-spoken-forms-from-talon branch from dcd23ec to 1454723 Compare October 24, 2023 20:05
@pokey pokey force-pushed the pokey/scope-info-provider branch 2 times, most recently from 19e052b to 8e36dcb Compare October 25, 2023 10:35
@pokey pokey force-pushed the pokey/get-custom-spoken-forms-from-talon branch from 4e94adb to 9f04db7 Compare October 25, 2023 10:39
@pokey pokey force-pushed the pokey/scope-info-provider branch 2 times, most recently from 4e411b2 to d3976ea Compare October 25, 2023 11:14
@pokey pokey force-pushed the pokey/get-custom-spoken-forms-from-talon branch 2 times, most recently from 46b65bb to d16ff17 Compare October 25, 2023 12:11
@pokey pokey force-pushed the pokey/scope-info-provider branch 2 times, most recently from 0a744f1 to 376e937 Compare October 25, 2023 12:28
@pokey pokey force-pushed the pokey/get-custom-spoken-forms-from-talon branch 2 times, most recently from 58fdd7c to f440866 Compare October 25, 2023 12:33
@pokey pokey force-pushed the pokey/scope-info-provider branch from 376e937 to a84251c Compare October 25, 2023 12:33
@pokey pokey force-pushed the pokey/get-custom-spoken-forms-from-talon branch from f440866 to a8048b9 Compare October 25, 2023 12:49
@pokey pokey force-pushed the pokey/scope-info-provider branch 2 times, most recently from 3f931dc to f456415 Compare October 25, 2023 12:51
@pokey pokey force-pushed the pokey/get-custom-spoken-forms-from-talon branch 2 times, most recently from 8873411 to f6768a2 Compare October 25, 2023 12:52
@pokey pokey force-pushed the pokey/scope-info-provider branch from f456415 to 41f18a8 Compare October 25, 2023 12:52
@pokey pokey force-pushed the pokey/get-custom-spoken-forms-from-talon branch from f6768a2 to e086762 Compare October 25, 2023 13:04
@pokey pokey force-pushed the pokey/scope-info-provider branch from 41f18a8 to 43fd688 Compare October 25, 2023 13:04
@pokey pokey mentioned this pull request Oct 25, 2023
Merged
pokey
pokey commented Oct 25, 2023
View reviewed changes
packages/cursorless-engine/src/scopeProviders/ScopeRangeWatcher.ts
ide().onDidChangeTextDocument(this.debouncer.run),
ide().onDidChangeTextEditorVisibleRanges(this.debouncer.run),
languageDefinitions.onDidChangeDefinition(this.debouncer.run),
languageDefinitions.onDidChangeDefinition(this.onChange),
Copy link
Member Author

@pokey pokey Oct 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes our scope visualizer auto-update faster during development

@pokey
Copy link
Member Author

pokey commented Oct 25, 2023 •
edited
Loading

Ok @AndreasArvidsson this one is ready too; let's wait to merge because it depends on #1940

pokey
pokey commented Oct 26, 2023
View reviewed changes
@pokey pokey mentioned this pull request Oct 27, 2023
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndreasArvidsson AndreasArvidsson AndreasArvidsson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pokey @AndreasArvidsson